Foreman

I agree this is a useful feature, I'll have to investigate how to implement it.

ok, I've found a way to do it, I'll start working on towards the following release

I have implemented a mechanism for hiding and revealing the unattended section in the gui and using this to de/activate the relevant validation checks. However when testing I found that I was not able to find a scenario in which this problem could occur.

If a legacy host has been imported via the rake tasks then all host fields are populated except the media, ptable, root password and serial. If this host then requires a new class or group then this is accessed via the edit page. The edit page will populate the ptable field unless the operating system of the host does not have any partition tables defined for it. In this case it might be more sensible to change the error message to "Ptable Cant be blank unless a custom partition has been defined\nEnsure that operatingsystem XXX has at least one partition table defined." Alternatively, a custom validation could be created that could distinguish between these to situations.

Marcello: if you have access to a current development installation, could you confirm that this problem is still present? Could you also describe how your host entries were created? If you created them whilst unattended => false and then switched to using unattended => true I would expect to see more errors as mac is not set.

Marcello: I think that I understand the problem now so no need to reply.

Rebased.
Tests pass

bumped to next version

Rebased and passes tests

Paul Kelly wrote:

Rebased and passes tests

as its been a long time since we reviewed this, what is the change in behavior? (that we'll know to update the release notes as well).

In an installation running with unattended enabled there may be hosts that have been imported but you do not wish to manage their build cycle.

When a host edited then it is marked as being managed if it has an architecture, an OS and either a disk or ptable value. (When a host is imported then the ptable is not set.) When this host is edited then the unattended section is not rendered, so any value in that section is not updated. When these values are applied to the host object then the validations notice that the host is not managed and do not enforce the presence of a ptable.

rebased
tested

Rebased and tested

Applied in changeset c9fff7c189b179aee2b3f0ab1c15c1e6206735e3.

The edit page after an empty create page looks wrong
The alerts enabled and host owner would look better below the comment box
Note the branch name change above

more formatting goodness added