Bug #239

Class import doesn't prune erased classes

Added by SyRenity Now almost 2 years ago. Updated over 1 year ago.

Status:Closed Start:05/06/2010
Priority:Normal Due date:
Assigned to:Paul Kelly % Done:

100%

Category:Importers
Target version:0.1-6
Backlog: Difficulity:
Votes: 0

Description

I imported some classes, which I later erased from disk.

Repeating import doesn't prune these classes.


Related issues

related to Foreman - Bug #386: ImportClasses should be callable from a rake task Closed 09/23/2010

Associated revisions

Revision adcd0374b6f62d483a1b324b30a98fbf98f45765
Added by Paul Kelly over 1 year ago

Fixes #239 - Erases environments and puppetclasses

The fix also includes a page in which the use selects the additions
and removals which they would wish to apply to their database.
Errors are reported and an opportunity is given to reapply the changes.

History

Updated by Ohad Levy over 1 year ago

  • Target version set to 0.1-6

Updated by Paul Kelly over 1 year ago

  • Status changed from New to Ready For Testing
  • Assigned to changed from Ohad Levy to Paul Kelly
  • Branch set to bug/239-prune-erased-classes

The fix also includes a page in which the user selects the additions and removals which they would wish to apply to their database.
Errors are reported and an opportunity is given to reapply the changes.

Updated by Ohad Levy over 1 year ago

Paul Kelly wrote:

The fix also includes a page in which the user selects the additions and removals which they would wish to apply to their database. Errors are reported and an opportunity is given to reapply the changes.

Would you mind adding tests?

Updated by Paul Kelly over 1 year ago

A few minor fixes
Tests added
NOTE that this branch consists of two commits, #239 and then #377, as the assert_select tests do not work without XHTML compliance

I would guess that git will find that the patch has already been applied if you were to apply this branch to develop after the separate #377 branch had been applied.

Updated by Paul Kelly over 1 year ago

  • % Done changed from 0 to 100

Updated by Ohad Levy over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF