Refactor #261

switch parameters to use a single reference id

Added by Paul Kelly over 1 year ago. Updated over 1 year ago.

Status:Closed Start:05/22/2010
Priority:Normal Due date:
Assigned to:Paul Kelly % Done:

100%
Category:Rails
Target version:0.1-6
Backlog: Difficulity:
Votes: 0

Description

Parameters use multiple id fields to refer to their associated object. This is not required.

Associated revisions

Revision aa1796f3efcd11e491ee2e55a91e6ae86529e8ea
Added by Paul Kelly over 1 year ago

Fixes #261 - parameters now use a single reference_id

This implementation uses STI but the table looks the same for all
variants. This is a little strange but it seems to work.

Also removed obsolete controllers and tests
Added more tests

History

Updated by Paul Kelly over 1 year ago

  • Subject changed from switch parameters to use STI to switch parameters to use a single reference id

Updated by Paul Kelly over 1 year ago

  • Category set to Rails
  • Status changed from New to Assigned

Ohad, I am unclear as to whether I have misunderstood your parameters implementation.
There are host parameters for all hosts for these keys ["hostmode", "hosttype", "longsitename", "puppetmaster", "sitename"]. Are these left over from an experiment or are we migrating to use these as the source of that information. I would also expect some of these to be domainparameters.

Updated by Paul Kelly over 1 year ago

  • Status changed from Assigned to Feedback
  • Branch set to refactor/261-parameters-use-reference_id

Rebased against develop
Tests pass.

Updated by Paul Kelly over 1 year ago

Refactored concrete class validations back into the abstract base class.
Removed obsolete controllers and their tests
Fixed some tests so as to always use a concrete class
Tests pass

Updated by Ohad Levy over 1 year ago

  • Target version set to 0.1-6

Updated by Paul Kelly over 1 year ago

Rebased
Fixed bug where hosts were marked :dependent => :destroy. Ouch!

Updated by Paul Kelly over 1 year ago

There were issues with the uniqueness constraint that are now fixed.
Added some tests, to be sure.

Updated by Paul Kelly over 1 year ago

  • Status changed from Feedback to Ready For Testing
  • % Done changed from 0 to 100

Updated by Ohad Levy over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF