Bug #26702: Inconsistent naming of the --upgrade-mongo-storage-engine flag - Installer - Foreman

Actions

Copy link

Bug #26702

closed

Inconsistent naming of the --upgrade-mongo-storage-engine flag

Added by Evgeni Golov about 5 years ago. Updated about 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Evgeni Golov

Category:

foreman-installer script

Target version:

Foreman - 1.23.0

Difficulty:

trivial

Triaged:

Yes

Bugzilla link:

1704806

Pull request:

https://github.com/theforeman/foreman-installer/pull/349

Fixed in Releases:

Foreman - 1.23.0

Found in Releases:

Red Hat JIRA:

Description

The flag is called --upgrade-mongo-storage-engine, but the installer sometimes forgets the -engine:

% git grep mongo-storage
katello/hooks/boot/21-mongo_storage_engine.rb:  '--upgrade-mongo-storage-engine',
katello/hooks/pre/30-upgrade.rb:      logger.info 'To upgrade to WiredTiger at a later time run foreman-installer with the --upgrade-mongo-storage flag.'
katello/hooks/pre/30-upgrade.rb:        f << "# Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage to upgrade to WiredTiger.\n" 
katello/hooks/pre/31-mongo_storage_engine.rb:  Kafo::Helpers.execute("sed -i -e 's/Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage to upgrade to WiredTiger./Do not remove'/g #{hiera_file}")
katello/hooks/pre_validations/30-mongo_storage_engine.rb:    fail_and_exit 'Concurrent use of --upgrade and --upgrade-mongo-storage-engine is not supported. '\
katello/hooks/pre_validations/30-mongo_storage_engine.rb:                  'Please run --upgrade first, then --upgrade-mongo-storage-engine.'

Related issues 1 (0 open — 1 closed)