Bug #329

Errors parsing RRDs

Added by Eric Shamow over 1 year ago. Updated over 1 year ago.

Status:Closed Start:06/24/2010
Priority:Normal Due date:
Assigned to:Ohad Levy % Done:

100%
Category:Puppet Reports
Target version:0.1-6
Backlog: Difficulity:
Votes: 0

Description

This is apparently related to an issue in Puppet --

http://projects.puppetlabs.com/issues/show/3949

Began getting the following for all reports:

Processing ReportsController#create to yml (for 127.0.0.1 at 2010-06-23 18:19:56) [POST]
Parameters: {"format"=>"yml", "action"=>"create", "controller"=>"reports", "report"=>"[FILTERED]"}
processing report for <puppet_client>
Failed to process report for <puppet_client> due to:undefined method `name' for "RRDtool":String
Completed in 31ms (View: 0, DB: 14) | 500 Internal Server Error [http://<puppet_server>/reports/create?format=yml]

Apparently this is due to RRDTool libraries not being loaded -- adding "require 'RRDTool'" in Foreman's environment.rb clears the problem up.

The fix was suggested by Volcane, it's not mine.

Associated revisions

Revision 5cd149934cd6cf09d98e3dbd5de8c1bcae85cf65
Added by Ohad Levy over 1 year ago

fixes #329 - trying to recover from serialization side effects

Revision 0e4f1b416d4dc40602ded94dc6c4bcc6aa90700e
Added by Ohad Levy over 1 year ago

fixes #329 - Errors parsing RRDs

History

Updated by Ohad Levy over 1 year ago

  • Target version set to 0.1-6

hmm... that's actually a puppet bug (effected version is 0.25.5) and is already fixed at http://projects.reductivelabs.com/issues/3949

I guess a quick workaround if foreman is to require RRD with a rescue block (e.g. for the people who don't have it installed).

Updated by Eric Shamow over 1 year ago

Agreed that it's a Puppet bug, but since Foreman is servicing Puppet and users are more likely to have a current Foreman but a slightly older Puppetmaster, I think a rescue block is a good idea -- and especially for those who are having the problem now with 0.25.5.

Updated by Ohad Levy over 1 year ago

  • Category set to Puppet Reports
  • Assigned to set to Ohad Levy

Updated by Ohad Levy over 1 year ago

  • Status changed from New to Ready For Testing
  • % Done changed from 0 to 100

Updated by Robin Bowes over 1 year ago

There's a typo in the changeset - it's RRDtool not RRDTool (small t).

Updated by Robin Bowes over 1 year ago

Let me be clear:

In config/initializers/puppet.rb, it should say:

if Facter.puppetversion == "0.25.5" 
  begin
    require 'RRDtool'
  rescue
    nil
  end
end

Updated by Ohad Levy over 1 year ago

Updated by Ohad Levy over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF