Project

General

Profile

Actions
Copy link

Refactor #35960

open

delete old searchinput

Added by Maria Agaphontzev over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
Maria Agaphontzev
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

in `webpack/assets/javascripts/react_app/components/common/SearchInput/`, is not used anywhere

Actions
Copy link
 #1

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

Note that we usually deprecate things before removing. For example, I don't know if any plugin uses this component.

Actions
Copy link
 #2

Updated by Maria Agaphontzev over 1 year ago

Ewoud Kohl van Wijngaarden wrote:

Note that we usually deprecate things before removing. For example, I don't know if any plugin uses this component.

I couldnt find any plugin in theforeman org that uses it, it was created for the breadcrumb switcher and its last use was removed in 2019. I can add a deprecation if it is still needed

Actions
Copy link
 #3

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

The reason we deprecate things that plugins could is it because there can be private plugins that we don't know about. I think it's a good habit to get into.

Actions
Copy link

Also available in: Atom PDF