Bug #36372: Display the config name correctly while creating, updating or deleting a virt-who config successfully. - virt-who configure - Foreman

Actions

Bug #36372

closed

Display the config name correctly while creating, updating or deleting a virt-who config successfully.

Added by Sayan Das about 1 year ago. Updated about 1 year ago.

Status:

Resolved

Priority:

Normal

Assignee:

Target version:

foreman_virt_who_configure-0.5.14

Difficulty:

easy

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_virt_who_configure/pull/162

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Create: https://github.com/theforeman/foreman_virt_who_configure/blob/master/app/controllers/foreman_virt_who_configure/configs_controller.rb#L36-L43

Update: https://github.com/theforeman/foreman_virt_who_configure/blob/master/app/controllers/foreman_virt_who_configure/configs_controller.rb#L51-L57

Delete: https://github.com/theforeman/foreman_virt_who_configure/blob/master/app/controllers/foreman_virt_who_configure/configs_controller.rb#L59-L65

We always seem to call @object and hence the Success message just prints something like '#<ForemanVirtWhoConfigure::Config:0x000055f23eed3d30>'. We should call @object.name here.

Actions

#1

Updated by Sayan Das about 1 year ago

Sayan Das wrote:

Create: https://github.com/theforeman/foreman_virt_who_configure/blob/master/app/controllers/foreman_virt_who_configure/configs_controller.rb#L36-L43

Update: https://github.com/theforeman/foreman_virt_who_configure/blob/master/app/controllers/foreman_virt_who_configure/configs_controller.rb#L51-L57

Delete: https://github.com/theforeman/foreman_virt_who_configure/blob/master/app/controllers/foreman_virt_who_configure/configs_controller.rb#L59-L65

We always seem to call @object and hence the Success message just prints something like '#<ForemanVirtWhoConfigure::Config:0x000055f23eed3d30>'. We should call @object.name here.

Small typo:

It's not @object but @config

And Affected BZs:

https://bugzilla.redhat.com/show_bug.cgi?id=2179721
https://bugzilla.redhat.com/show_bug.cgi?id=2179725
https://bugzilla.redhat.com/show_bug.cgi?id=2168716

Actions

#2

Updated by The Foreman Bot about 1 year ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman_virt_who_configure/pull/162 added

Actions

#3

Updated by Chris Roberts about 1 year ago

Status changed from Ready For Testing to Resolved
Target version set to foreman_virt_who_configure-0.5.14
Triaged changed from No to Yes

Actions

Also available in: Atom PDF