Bug #36931
closedBulk Actions not handling kwargs correctly
Description
Description of problem:
Consider the following call
async_task(::Actions::BulkAction, ::Actions::Katello::Repository::Sync, [::Katello::Repository.librar.first], skip_metadata_check: true)
What ends up happening is that keyword arguments like 'skip_metadata_check' gets converted from symbols to string when BulkAction passes to the Sync.
Actions like sync expect expect them to be symbols like {:skip_metadata_check => true} but what gets passed to it from BulkActions is {'skip_metadata_check' => true} making all kwargs passed to it useless.
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce:
1.In the console run the following line (assuming you have at least one repo)
ForemanTasks.sync_task(::Actions::BulkAction, ::Actions::Katello::Repository::Sync, [::Katello::Repository.library.first], skip_metadata_check: true)
2. Go to https://<sat-fqdn>/foreman_tasks/dynflow
3. Check the stopped and uncheck the pending and filter the search
4. You should see tasks Actions::Katello::Repository::Sync followed by Actions::BulkAction
5. Click show on the sync task
6. Check the params sent to the Actions::Katello::Repository::Sync
7. See the value set for skip_metadata_check
Actual results:
skip_metadata_check: false
Expected results:
skip_metadata_check: true
Additional info:
Any bulk action that accepts key word arguments are affected by this.
Updated by The Foreman Bot 6 months ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman-tasks/pull/731 added
Updated by The Foreman Bot 6 months ago
- Fixed in Releases foreman-tasks-8.1.1 added
Updated by Adam Ruzicka 6 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset 5361d22cd9a41f0531c793afdc8fbaaa19aed545.
Updated by Adam Ruzicka 6 months ago
- Fixed in Releases foreman_tasks-9.0.0 added
- Fixed in Releases deleted (
foreman-tasks-8.1.1)
Updated by Adam Ruzicka 6 months ago
- Fixed in Releases foreman_tasks-8.3.3 added