Foreman » Installer

archive puppet lock

if not cancelled as recommended in GitHub documentation
https://docs.github.com/en/actions/learn-github-actions/expressions#always

add GHA based tests

explicitly install racc on Ruby 3.3+

Fixes #37392 - Exclude vendor dir in .rubocop.yaml

Ensure the system encoding is UTF-8

Checking for C is not sufficient, it could also be ISO-8859 or something
else.

By checking Enconding.locale_charmap we can check one place and have one
way to spell "UTF-8". ENV['LANG'] and ENV['LC_*'] support a variety of...

Also add semverse to test group

Support a maximum version in pin_modules rake task

Factor out FakePuppetfile so it can be tested in rspec

Fix RSpec/ContextWording cop

Fix Performance/Casecmp cop

Fix Rubocop Style/FileWrite

Fix Rubocop Style/ConcatArrayLiterals

Fix Rubocop Style/RedundantConstantBase

Fix Rubocop Layout/LineEndStringConcatenationIndentation

Fix Rubocop Layout/LineContinuationLeadingSpace

Fix Rubocop Layout/IndentationConsistency

Fix Rubocop Layout/RescueEnsureAlignment & Layout/BeginEndAlignment

Fix Rubocop Layout/IndentationWidth

Fix Rubocop Style/GlobalStdStream

Fix Rubocop Layout/EndAlignment

Fix Rubocop Style/StringConcatenation

Fix Rubocop Style/SoleNestedConditional

Update Rubocop version & fix offenses

Fixes #37297 - Use SCRAM passwd encryption with PostgreSQL

PostgreSQL supports SCRAM encryption and PostgreSQL 14 will also default
to this. Moving to it sooner helps removing md5 from the system.

Fixes #37296 - Drop foreman-hooks

Fixes #37261 - Add gitlab ci configuration

Fixes #37063 - Add feature in katello-certs-check to verify if CA bundle has any certificates with trust rules

- Add feature to verify if provided CA bundle has certificates with trust rules
 - Add test case for the new feature
 - Fix indentation on function check-ca-bundle-size

Fixes #37306 - Reset Puppetserver ciphers if needed

In foreman-installer 2.0 we updated¹ the ciphers for puppetserver, but
didn't introduce a migration to update existing installations. Users
from very old installs will still use the insecure ciphers. This breaks...

Refs #37298 - Add migrations to drop setup plugin

Fixes: e4338f1d7ea9 ("Fixes #37298 - Drop foreman_setup plugin")

Fixes #37298 - Drop foreman_setup plugin

This plugin is unmaintained and largely broken.

Refs #37291 - Only reset puppetserver's JVM if it's /usr/bin/java

The intent was to only reset it if it was the default value, not just
any value.

Fixes: 19310592c8d7f16b2c59f0995463e7ae913e01ef ("Refs #37291 - Reset Puppet's java_bin")

Refs #37291 - Reset Puppet's java_bin

In theforeman/puppet 19.2.0 the puppet::server_jvm_java_bin parameter
was changed to undef and determined at runtime. This helps with Puppet 8
upgrades.

Remove smart_proxy_dynflow_core.service

Drop inclusion of Qpid module

Check if /opt/puppetlabs is mounted noexec

It was reported¹ that facter can't be found if puppet is installed on
a filesystem that's mounted noexec.

[1]: https://community.theforeman.org/t/problem-foreman-installer-ruby-spawn-errno-enoent/34332/5

Allow puppetlabs/apache 12.x

We need 12.0.3+ for Puppet 8 support due to https://github.com/puppetlabs/puppetlabs-apache/pull/2525

Fixes #37177 - Upgrade PostgreSQL to 13 on EL8

Bump develop to 3.11.0-develop

build packit for el9

Refs #37097 - Use .tar.gz file extension for tarballs

This aligns with the actual content, which is a gzipped tarball.

pin puppetlabs/apache to < 12 until our modules support it

Build packit on rhel-8

This is consistent with how we eventually build it. It also switches yum
over to use HTTPS.

Refs #36843: Pass array to capture2e as arguments

fix packit to use prod nightly

Bump develop to 3.10.0-develop

Add hammer foreman_rh_cloud package

Ensure Puppet 8 support

Allow puppetlabs/postgresql 10.x

Fail early if cert files don't exist

While it usually doesn't happen, this showed up in my manual testing and
the output is confusing.

Redirect errors from tput to /dev/null

In minimal environments tput may not be present or work. In that case it
falls back to not having colors, which is fine. The user doesn't need to
be warned about this.

Fixes #36843 - run katello-certs-check in fp-certs-generate

Update to stdlib 9.x

This also requires kafo 7.3 to parse multi line type aliases.

Refs #36801: Set Redis as the default cache on upgrade

Raise minimum Puppet version to 7.9.0

puppetlabs/apache requires at least 7.9.0, not 7.0.0.

Pin puppetlabs/postgresql to < 10

Due to puppetlabs/stdlib 9.x requirement.

Update manpage to reflect --reset-data option

Fixes: 7ca7d88d42ec5a340c3af256096fdede35a3ebe9

Refs #36760 - Reset candlepin key- and truststore

This takes a 2 step approach where the cached password is removed during
migration (which ends up running during the RPM installation). The
installer then handles replacing the stores when it really runs.

Fixes #36784 - Drop MaxRequestsPerChild tuning

Since puppetlabs-apache 9.0.0 this tuning does nothing, since the
parameter was dropped. For older versions it may also trigger
https://bugzilla.redhat.com/show_bug.cgi?id=2238325 and the default
tuning doesn't set it, so is likely unaffected.

Fixes #36694 - Show failed resources on installation

Kafo 7.1.0 has started to capture Puppet reports and in 7.2.0 it was
extended for better messages. This allows showing the failed resources
which makes it easier to troubleshoot failures. Ideally speaking the...

Remove qpid tunings from tuning profiles

Remove unused key enable_katello_agent from foreman.hiera/common.yaml

katello-agent was deprecated before, now it is removed altogether

Make specs RuboCop clean

Bump develop to 3.9.0-develop

Fix apache::trace_enable example

In puppetlabs-apache 10.0 the trace_enable became stricter and only
accepts certain strings. YAML converts Off to a boolean, which breaks.
By quoting it we still have a valid example.

Fixes #36311 - expose apache::mod::status in the installer

Refs #35943 - Switch to puppetlabs/vcsrepo

Our theforeman/puppet module has switch from our own custom module to
the generic puppetlabs/vcsrepo. This saves maintenance on our side and
for users it provides more functionality. In large environments it's
already common and allows reuse.

Fixes #36620 - Puppet module replace whitelist with allowlist

Refs #36573 - Drop puppet::server_foreman_url value if redundant

theforeman/puppetserver_foreman has started to default to copying the
value from foreman_proxy::foreman_base_url when unspecified.
theforeman/puppet has removed its default. This completes it by removing...

Add a rake modules task

This is a small wrapper around librarian-puppet so you don't have to do
the complete build. If you don't need the parser cache, this is a lot
faster.

Use a shared context to do migration testing

By using a shared context we can easily write more migration test
without repeating the same context over and over again.

Fixes #36567 - Make katello-certs-check failures fatal

Prior to 688d0a7dc08fc78407ed84466f3b0861c3cbfc2f the execute! method
was used, which caused the installer to exit if katello-certs-check
failed. That commit changed it to only output the error on failure, but...

Fixes #36319 - Add Promxox support

also pin puppetlabs/apt, 9.1.0 wants stdlib 9

Pin puppetlabs/stdlib to version < 9

Allow puppetlabs-apache 9.x

Pin Puppet module versions to ~> x.y.z

This is essentially the same as wel already did, but it's much easier to
change if you need to bump a .y version. Instead of two places, it's now
just two. It also simplifies the code to do the pinning.

Visually align module versions in Puppetfile

This makes the diff when pinning smaller.

Bump develop to 3.8.0-develop

Fixes #36377 - Sunsetting foreman_column_view because functionality being integrated in Foreman itself

allow kafo 7.x

correct upstream tag template in packit config

add packit config

Fixes #36345 - Drop Puppet 6 support

Puppet 6 is end of life and more and more modules are dropping support.
Rather than pinning modules this takes the approach of dropping Puppet
6.

Fixes #36238 - drop all data owned by the DB user, not only tables

The old logic (introduced all the way back in [1]) took a list of all
tables and executed a `DROP … CASCADE` on them. While this is sufficient
for tables and the associated sequences, triggers etc [2][3], it will...

Ensure Ansible callback from the Ansible collection is used

This is only applied to the Foreman scenario because the parameter
always Red Hat always defaulted to the collection parameter since it was
introduced. It's mostly for Debian, but should be safe for RH too so no...

Fixes #36211 - Add PowerDNS and Route53 plugins to scenarios

These plugins have long been packaged, but the Foreman Proxy module has
started to include the correct provided if needed¹. This means users
now need to be able to configure the parameters, where they could...

Correct the minimum Puppet version bound

Modules we include have raised the minimum version to 6.24.0, which
introduced the ability to specify the exec command as an array.

Fixes #36170 - drop memcache plugin support

it's broken since Foreman 3.4 and nobody is fixing it

Bump develop to 3.7.0-develop

Fixes #35985 - Use Katello integration in theforeman/puppet

Refs #35925: Add SSH keepalive for Ansible

Pin puppetlabs/apache to ~> 8.3

This should prevent attempting to pull in version 9.x. There are several
breaking changes, but they largely don't affect us. Once all modules are
updated, this pin can be relaxed again.

Fixes #35800 - Add foreman_kernel_care plugin support

This is a Foreman plugin that depends on Katello, which is why it's only
added to the katello scenario.

Bump develop to 3.5.0-develop

Update 20220406141823_foreman_google.rb

Update katello-answers-before.yaml

Update katello-answers-before.yaml

Update config/foreman.migrations/20220406150414_foreman_google.rb

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Fixes #35677 - Add ForemanGoogle plugin

drop chef plugin